Replace most sleeps with waitForSpinnerDone#7450
Closed
LeeDr wants to merge 3 commits intoelastic:masterfrom
Closed
Replace most sleeps with waitForSpinnerDone#7450LeeDr wants to merge 3 commits intoelastic:masterfrom
LeeDr wants to merge 3 commits intoelastic:masterfrom
Conversation
Contributor
|
@LeeDr Do you still intend to get this PR over the line? |
Author
|
This is really out of date at this point. It's still a good idea, but it might be replaced by a new event that fires when visualizations are finished loading. So I'll close this and take a look at it again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title sums it up. I think its better to wait for the spinner bar to be hidden before checking the page than to either sleep, or tryForTime multiple times. Waiting for the spinner to be hidden eliminates most of the tryForTime failures but not all. So I've left most of the tryForTime calls as-is.
Oops, I've implemented this on top of my #7442 PR to switch to chrome browser.